-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations to GroupBy objects #1889
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
==========================================
- Coverage 94.19% 91.34% -2.85%
==========================================
Files 40 40
Lines 9939 9858 -81
==========================================
- Hits 9362 9005 -357
- Misses 577 853 +276
Continue to review full report at Codecov.
|
87e2a6d
to
2ae11b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests.
#type: ignore
's in b20a3b1 are mostly because mypy cannot identify_attributes
ofself
.We are considering adding abstract methods to
GroupBy
to help mypy identify. However, this should be a separate task.