Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to GroupBy objects #1889

Merged
merged 7 commits into from
Nov 6, 2020

Conversation

xinrong-meng
Copy link
Contributor

@xinrong-meng xinrong-meng commented Nov 4, 2020

#type: ignore's in b20a3b1 are mostly because mypy cannot identify _attributes of self.

We are considering adding abstract methods to GroupBy to help mypy identify. However, this should be a separate task.

@xinrong-meng xinrong-meng marked this pull request as draft November 4, 2020 20:59
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #1889 into master will decrease coverage by 2.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   94.19%   91.34%   -2.85%     
==========================================
  Files          40       40              
  Lines        9939     9858      -81     
==========================================
- Hits         9362     9005     -357     
- Misses        577      853     +276     
Impacted Files Coverage Δ
databricks/koalas/frame.py 93.40% <100.00%> (-3.33%) ⬇️
databricks/koalas/groupby.py 90.96% <100.00%> (-0.23%) ⬇️
databricks/koalas/series.py 95.68% <100.00%> (-1.29%) ⬇️
databricks/koalas/usage_logging/__init__.py 25.66% <0.00%> (-66.65%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 47.82% <0.00%> (-52.18%) ⬇️
databricks/koalas/__init__.py 76.66% <0.00%> (-13.34%) ⬇️
databricks/conftest.py 88.13% <0.00%> (-11.87%) ⬇️
databricks/koalas/spark/functions.py 88.88% <0.00%> (-7.41%) ⬇️
databricks/koalas/accessors.py 86.06% <0.00%> (-6.97%) ⬇️
databricks/koalas/namespace.py 78.45% <0.00%> (-4.85%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5d866...15262ed. Read the comment docs.

@xinrong-meng xinrong-meng marked this pull request as ready for review November 5, 2020 16:54
databricks/koalas/groupby.py Outdated Show resolved Hide resolved
databricks/koalas/groupby.py Outdated Show resolved Hide resolved
databricks/koalas/groupby.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@xinrong-meng xinrong-meng merged commit 3237002 into databricks:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants