Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby.nunique #617

Merged
merged 12 commits into from
Aug 19, 2019
Merged

Groupby.nunique #617

merged 12 commits into from
Aug 19, 2019

Conversation

RainFung
Copy link
Contributor

@RainFung RainFung commented Aug 2, 2019

add parameter to check if all columns to be agged

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #617 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   92.97%   92.99%   +0.01%     
==========================================
  Files          31       31              
  Lines        5085     5094       +9     
==========================================
+ Hits         4728     4737       +9     
  Misses        357      357
Impacted Files Coverage Δ
databricks/koalas/missing/groupby.py 100% <ø> (ø) ⬆️
databricks/koalas/series.py 93.03% <100%> (+0.08%) ⬆️
databricks/koalas/groupby.py 81.92% <100%> (+0.36%) ⬆️
databricks/koalas/frame.py 94.64% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c0299...ad99a8e. Read the comment docs.

databricks/koalas/groupby.py Outdated Show resolved Hide resolved
@HyukjinKwon
Copy link
Member

@RainFung, can you resolve the conflicts? looks close to go.

@HyukjinKwon
Copy link
Member

Argh, this conflict was caused by merging #622. Can you update please?

@HyukjinKwon
Copy link
Member

@RainFung, I will merge this one as soon as the tests pass

@RainFung
Copy link
Contributor Author

@RainFung, I will merge this one as soon as the tests pass

Can you solve this before merge?#617 (comment)

@softagram-bot
Copy link

Softagram Impact Report for pull/617 (head commit: ad99a8e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to support@softagram.com

@RainFung
Copy link
Contributor Author

wait to be code reviewed.

@HyukjinKwon HyukjinKwon merged commit c87a849 into databricks:master Aug 19, 2019
@RainFung RainFung deleted the groupby.nunique branch August 19, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants