Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impelment DataFrame.keys #937

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Impelment DataFrame.keys #937

merged 2 commits into from
Oct 19, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Oct 18, 2019

An alias for columns.

>>> df = ks.DataFrame([[1, 2], [4, 5], [7, 8]],
...                   index=['cobra', 'viper', 'sidewinder'],
...                   columns=['max_speed', 'shield'])
>>> df
            max_speed  shield
cobra               1       2
viper               4       5
sidewinder          7       8

>>> df.keys()
Index(['max_speed', 'shield'], dtype='object')

>>> df.to_pandas().keys()
Index(['max_speed', 'shield'], dtype='object')

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

databricks/koalas/frame.py Show resolved Hide resolved
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itholic
Copy link
Contributor Author

itholic commented Oct 19, 2019

@ueshin @HyukjinKwon Thanks for commenting!! added it :)

@softagram-bot
Copy link

Softagram Impact Report for pull/937 (head commit: 3085759)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@codecov-io
Copy link

codecov-io commented Oct 19, 2019

Codecov Report

Merging #937 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   94.46%   94.46%   +<.01%     
==========================================
  Files          34       34              
  Lines        6382     6383       +1     
==========================================
+ Hits         6029     6030       +1     
  Misses        353      353
Impacted Files Coverage Δ
databricks/koalas/missing/frame.py 100% <ø> (ø) ⬆️
databricks/koalas/frame.py 96.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465861c...3085759. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 1fe8eb7 into databricks:master Oct 19, 2019
@itholic itholic deleted the f_keys branch October 23, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants