Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add levels property for MultiIndex #973

Merged
merged 10 commits into from
Nov 5, 2019

Conversation

charlesdong1991
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 3, 2019

Codecov Report

Merging #973 into master will decrease coverage by 1.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   94.57%   93.09%   -1.49%     
==========================================
  Files          34       34              
  Lines        6487     6572      +85     
==========================================
- Hits         6135     6118      -17     
- Misses        352      454     +102
Impacted Files Coverage Δ
databricks/koalas/missing/indexes.py 100% <ø> (ø) ⬆️
databricks/koalas/indexes.py 96.35% <100%> (-0.28%) ⬇️
databricks/koalas/usage_logging/__init__.py 24.54% <0%> (-72.73%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 78.72% <0%> (-6.65%) ⬇️
databricks/conftest.py 91.48% <0%> (-6.39%) ⬇️
databricks/koalas/frame.py 95.65% <0%> (-0.38%) ⬇️
databricks/koalas/generic.py 95.26% <0%> (-0.31%) ⬇️
databricks/koalas/plot.py 94.04% <0%> (-0.24%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2286bd...95da9e3. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM. (#973 (comment))

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, let's add a link in docs/source/reference/indexing.rst?

databricks/koalas/indexes.py Outdated Show resolved Hide resolved
databricks/koalas/indexes.py Show resolved Hide resolved
@softagram-bot
Copy link

Softagram Impact Report for pull/973 (head commit: 95da9e3)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@ueshin
Copy link
Collaborator

ueshin commented Nov 5, 2019

LGTM, pending tests.

@ueshin
Copy link
Collaborator

ueshin commented Nov 5, 2019

Thanks! merging.

@ueshin ueshin merged commit 23dc764 into databricks:master Nov 5, 2019
@HyukjinKwon
Copy link
Member

I had a offline discussion with @ueshin. It requires to collect all data into driver side (similar discussion at #952). Let me take this out in today's release for now.

HyukjinKwon added a commit that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants