Add objectValues and objectValuesAll to stdlib #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvgica
commented
Nov 25, 2020
|
|
||
| def getObjValuesFromKeys(ev: EvalScope, fs: FileScope, v1: Val.Obj, keys: Seq[String]): Val.Arr = { | ||
| Val.Arr(keys.map { k => | ||
| Val.Lazy(v1.value(k, -1)(fs, ev)) |
There was a problem hiding this comment.
I was a bit unsure about the offset argument here, but saw -1 used elsewhere. Let me know if it should be different.
lihaoyi-databricks
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #103. I believe my implementation takes the same approach (in Scala) as the jsonnet implementation in google/jsonnet#858.
Tested by running
mill __.test.test, everything passes.