Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exporting of databricks_service_principal resource #1811

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 2, 2022

plus small improvements like references for single_user_name, etc.

plus small improvements like references for `single_user_name`, etc.
@alexott alexott added the exporter TF configuration generator label Dec 2, 2022
@alexott alexott requested review from nfx and a team December 2, 2022 16:44
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #1811 (720f658) into master (93a035e) will increase coverage by 0.03%.
The diff coverage is 97.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
+ Coverage   89.96%   89.99%   +0.03%     
==========================================
  Files         142      142              
  Lines       11276    11337      +61     
==========================================
+ Hits        10144    10203      +59     
- Misses        722      723       +1     
- Partials      410      411       +1     
Impacted Files Coverage Δ
exporter/importables.go 89.34% <95.12%> (+0.07%) ⬆️
exporter/util.go 86.61% <100.00%> (+2.21%) ⬆️
scim/data_service_principal.go 100.00% <100.00%> (ø)
scim/data_service_principals.go 100.00% <100.00%> (ø)
scim/resource_service_principal.go 97.24% <100.00%> (ø)

@nfx nfx changed the title Add exporting of databricks_service_principal resource Added exporting of databricks_service_principal resource Dec 5, 2022
@nfx nfx enabled auto-merge (squash) December 5, 2022 11:58
@nfx nfx merged commit 318fa53 into master Dec 5, 2022
@nfx nfx mentioned this pull request Dec 14, 2022
@nfx nfx deleted the exporter-service-principal branch January 25, 2023 15:26
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
…s#1811)

* Add exporting of `databricks_service_principal` resource

plus small improvements like references for `single_user_name`, etc.

* make SP name unique & improve code coverage

* better name generation for service principals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants