Remove deprecated params from bucket #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `acl` and `versioning` parameters are deprecated on the aws_s3_bucket resource. The docs recommend using aws_s3_bucket_acl and aws_s3_bucket_versioning resources instead. From what I can gather, this helps with drift detection in Terraform.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 146 146
Lines 11906 11906
=======================================
Hits 10751 10751
Misses 746 746
Partials 409 409 |
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
The `acl` and `versioning` parameters are deprecated on the aws_s3_bucket resource. The docs recommend using aws_s3_bucket_acl and aws_s3_bucket_versioning resources instead. From what I can gather, this helps with drift detection in Terraform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aclandversioningparameters are deprecated on theaws_s3_bucketresource. The docs recommend usingaws_s3_bucket_aclandaws_s3_bucket_versioningresources instead. From what I can gather, this helps with drift detection in Terraform.