Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize assessment dashboard to increase readability #738

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Reorganize assessment dashboard to increase readability #738

merged 4 commits into from
Jan 3, 2024

Conversation

dmoore247
Copy link
Contributor

@dmoore247 dmoore247 commented Dec 23, 2023 •
edited

Closes #734 #543
image

@dmoore247 dmoore247 requested a review from a team as a code owner December 23, 2023 22:57
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2552cf7) 80.01% compared to head (8c38484) 80.01%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files          43       43           
  Lines        4603     4603           
  Branches      859      859           
=======================================
  Hits         3683     3683           
  Misses        696      696           
  Partials      224      224

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nfx
nfx requested changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict and provide a screenshot of the change as part of the PR description

src/databricks/labs/ucx/queries/assessment/main/01_2_assessment_summary.sql Outdated Show resolved Hide resolved
@dmoore247 dmoore247 self-assigned this Jan 2, 2024
@dmoore247 dmoore247 requested a review from nfx January 2, 2024 16:19
@nfx nfx disabled auto-merge January 3, 2024 16:00
@nfx nfx merged commit 06c666c into main Jan 3, 2024
7 checks passed
@nfx nfx deleted the fix/assessment-readability branch January 3, 2024 16:00
nfx added a commit that referenced this pull request Jan 12, 2024
@nfx
Release v0.9.0
b94cdd8 
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)).
* Added `TableMapping` functionality to table migrate ([#752](#752)).
* Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)).
* Added functionality to determine migration method based on DBFS Root ([#759](#759)).
* Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)).
* Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)).
* Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)).
* Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)).
* Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)).
* Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)).
* Improved error message inference from failed workflow runs ([#753](#753)).
* Moved `TablesMigrate` to a separate module ([#747](#747)).
* Reorganized assessment dashboard to increase readability ([#738](#738)).
* Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)).
* Verify metastore exists in current workspace ([#735](#735)).
@nfx nfx mentioned this pull request Jan 12, 2024
Merged
nfx added a commit that referenced this pull request Jan 12, 2024
@nfx
Release v0.9.0 (#776)
646c678 
* Added assessment step to estimate the size of DBFS root tables
([#741](#741)).
* Added `TableMapping` functionality to table migrate
([#752](#752)).
* Added `databricks labs ucx move` command to move tables and schemas
between catalogs
([#756](#756)).
* Added functionality to determine migration method based on DBFS Root
([#759](#759)).
* Added `get_tables_to_migrate` functionality in the mapping module
([#755](#755)).
* Added retry and rate limit to rename workspace group operation and
corrected rate limit for reflecting account groups to workspace
([#751](#751)).
* Adopted `databricks-labs-blueprint` library for common utilities to be
reused in the other projects
([#758](#758)).
* Converted `RuntimeBackend` query executions exceptions to SDK
exceptions ([#769](#769)).
* Fixed issue with missing users and temp groups after workspace-local
groups migration and skip table when crawling table size if it does not
exist anymore ([#770](#770)).
* Improved error handling by not failing group rename step if a group
was removed from account before reflecting it to workspace
([#762](#762)).
* Improved error message inference from failed workflow runs
([#753](#753)).
* Moved `TablesMigrate` to a separate module
([#747](#747)).
* Reorganized assessment dashboard to increase readability
([#738](#738)).
* Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0
([#773](#773)).
* Verify metastore exists in current workspace
([#735](#735)).
FastLee pushed a commit that referenced this pull request Jan 19, 2024
@dmoore247 @FastLee
Reorganize assessment dashboard to increase readability (#738)
2b02adf 
Closes #734 
<img width="1673" alt="image"
src="https://github.com/databrickslabs/ucx/assets/1122251/42e8eba8-9a89-4a20-958d-1209f51e542d">
FastLee pushed a commit that referenced this pull request Jan 19, 2024
@nfx @FastLee
Release v0.9.0 (#776)
07f977e 
* Added assessment step to estimate the size of DBFS root tables
([#741](#741)).
* Added `TableMapping` functionality to table migrate
([#752](#752)).
* Added `databricks labs ucx move` command to move tables and schemas
between catalogs
([#756](#756)).
* Added functionality to determine migration method based on DBFS Root
([#759](#759)).
* Added `get_tables_to_migrate` functionality in the mapping module
([#755](#755)).
* Added retry and rate limit to rename workspace group operation and
corrected rate limit for reflecting account groups to workspace
([#751](#751)).
* Adopted `databricks-labs-blueprint` library for common utilities to be
reused in the other projects
([#758](#758)).
* Converted `RuntimeBackend` query executions exceptions to SDK
exceptions ([#769](#769)).
* Fixed issue with missing users and temp groups after workspace-local
groups migration and skip table when crawling table size if it does not
exist anymore ([#770](#770)).
* Improved error handling by not failing group rename step if a group
was removed from account before reflecting it to workspace
([#762](#762)).
* Improved error message inference from failed workflow runs
([#753](#753)).
* Moved `TablesMigrate` to a separate module
([#747](#747)).
* Reorganized assessment dashboard to increase readability
([#738](#738)).
* Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0
([#773](#773)).
* Verify metastore exists in current workspace
([#735](#735)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

@zpappa zpappa Awaiting requested review from zpappa zpappa is a code owner automatically assigned from databrickslabs/ucx-write

Assignees

@dmoore247 dmoore247

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard 2nd row is cramped, not fully displaying on my laptop screen
2 participants
@dmoore247 @nfx