Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly link to other lessons when they are referenced #436

Closed
maneesha opened this issue Jan 18, 2020 · 3 comments
Closed

Correctly link to other lessons when they are referenced #436

maneesha opened this issue Jan 18, 2020 · 3 comments
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors

Comments

@maneesha
Copy link
Contributor

In the indexing and slicing lesson, there is a place where it says

Note that the weight column of our DataFrame contains many null or NaN values. We will explore ways of dealing with this in Lesson 03.

Generally speaking, if other lessons are referenced, these should be linked to, so that it is easier to quickly navigate to that lesson.

Also, in this case, it is lesson 4 that introduces concepts of null data values, not lesson 3.
@maxim-belkin
Copy link
Contributor

Thanks, Maneesha. Your're correct -- we should definitely link to the next episode. Moreover, we should also fix the wording: here, we're talking about Lesson episode, not Lesson itself.

I'm marking this as "Good first issue" and "help wanted"

Thanks for spotting this.

@maxim-belkin maxim-belkin added good first issue Good issue for first-time contributors help wanted Looking for Contributors labels Jun 7, 2020
@Isaac-Jones
Copy link
Contributor

I believe this fixed the issue. Also, this is my first time so I'm not sure if you prefer to get a link here or not. #481

@maxim-belkin
Copy link
Contributor

Thank you, @Isaac-Jones! I'll review your PR in a little bit.

zkamvar pushed a commit that referenced this issue May 8, 2023
@Isaac-Jones
03-index-slice-subset.md: properly link to the next episode, fix word…
6daf622 
…ing (#481)

Fixes: #436

- Updated text to specify it as the next episode instead of lesson
- Updated link to correct format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maneesha @maxim-belkin @Isaac-Jones