Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 03-index-slice-subset.md #481

Merged
merged 7 commits into from Nov 30, 2020
Merged

Update 03-index-slice-subset.md #481

merged 7 commits into from Nov 30, 2020

Conversation

Isaac-Jones
Copy link
Contributor

Updated lesson to comply with Issue 436

Changed "Lesson 3" reference to the correct "Lesson 4" reference, along with a link to the lesson.

@Isaac-Jones
Update 03-index-slice-subset.md
77e8df0 
Updated lesson to comply with Issue 436
@Isaac-Jones Isaac-Jones marked this pull request as draft November 26, 2020 00:00
@Isaac-Jones Isaac-Jones marked this pull request as ready for review November 26, 2020 00:01
@Isaac-Jones Isaac-Jones mentioned this pull request Nov 26, 2020
Closed
maxim-belkin
maxim-belkin suggested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes make perfect sense, @Isaac-Jones, so I've got only a couple of comments.
Thank you for your contribution to the lesson!!! 👍

_episodes/03-index-slice-subset.md Outdated Show resolved Hide resolved
@maxim-belkin maxim-belkin added status:in progress Contributor working on issue type:bug Code included in the lesson needs to be fixed type:enhancement Propose enhancement to the lesson labels Nov 26, 2020
@Isaac-Jones Isaac-Jones marked this pull request as draft November 30, 2020 21:12
@maxim-belkin maxim-belkin removed the status:in progress Contributor working on issue label Nov 30, 2020
@Isaac-Jones
Copy link
Contributor Author

I am having trouble with the linking format... Is this what it is supposed to look like?

maxim-belkin
maxim-belkin approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you, Isaac! Yes, the syntax for linking to other episodes is not as straightforward as it could've been but you figured it out, so great job!

@maxim-belkin maxim-belkin marked this pull request as ready for review November 30, 2020 21:46
@maxim-belkin maxim-belkin merged commit 31c6a6c into datacarpentry:gh-pages Nov 30, 2020
maxim-belkin added a commit to maxim-belkin/python-ecology-lesson that referenced this pull request Mar 15, 2021
@maxim-belkin
Makefile: fix comment in front of lesson-check (datacarpentry#481)
115a735 
Comments prepended with `##` appear in the output of `make commands`.
This commit changes `#` to `##` in front of `lesson-check` so that it
appears in the output of `make commands`.
zkamvar pushed a commit that referenced this pull request May 8, 2023
@Isaac-Jones
03-index-slice-subset.md: properly link to the next episode, fix word…
6daf622 
…ing (#481)

Fixes: #436

- Updated text to specify it as the next episode instead of lesson
- Updated link to correct format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxim-belkin maxim-belkin maxim-belkin approved these changes

Assignees
No one assigned
Labels
type:bug Code included in the lesson needs to be fixed type:enhancement Propose enhancement to the lesson
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Isaac-Jones @maxim-belkin