Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert episode 9 plotting to ggplot #182

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

juanfung
Copy link
Contributor

@juanfung juanfung commented Jul 11, 2018

Per #133: This is a straight conversion of episode 9 plots to use ggplot. Also, following earlier conventions, explicitly calling library(sf) in the second code chunk.

An important remark for follow-up:

  • geom_sf automatically transforms the CRS of additional layers (see second example in documentation here). Thus, the fourth plot shows the tower point in the correct location (it shouldn't appear on the map since each layer has a different CRS).

I will open an issue corresponding to this part of the episode.

@juanfung juanfung requested a review from a team July 11, 2018 17:00
@ErinBecker
Copy link
Contributor

Thanks @juanfung, this looks great to me and the checks are passing. I'll go ahead and merge and then resolve conflicts on #180 there.

@ErinBecker ErinBecker merged commit 0ba0a53 into master Jul 11, 2018
ErinBecker pushed a commit that referenced this pull request Jul 12, 2018
zkamvar pushed a commit that referenced this pull request Feb 7, 2023
…nd-10

Convert episode 9 plotting to ggplot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants