Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General cleanup #228

Merged
merged 20 commits into from
Aug 13, 2018
Merged

General cleanup #228

merged 20 commits into from
Aug 13, 2018

Conversation

ErinBecker
Copy link
Contributor

@ErinBecker ErinBecker commented Jul 30, 2018 •
edited
Loading

For episodes 3 and 4:

  • Adds key points
  • Standardizes formatting
  • Cleans up minor typos

For episode 5, the above plus:

@ErinBecker ErinBecker mentioned this pull request Jul 31, 2018
Closed
@ErinBecker
Copy link
Contributor Author

I'll keep adding commits to this PR as I go, but please feel free to review and/or merge at any time. I'll update each time I finish an episode, so the changes should always be in a stage where they're ready to review/merge. @datacarpentry/geospatial-maintainers

@ErinBecker ErinBecker requested a review from r4space August 1, 2018 20:03
@ErinBecker
Copy link
Contributor Author

Episodes 6 and 7 added. There's something wrong with the legends in episode 7, but I can't figure out how to fix it right now. Those problems already appear in the rendered lesson, so please review this PR independently of the figure issues.

@ErinBecker
Copy link
Contributor Author

Same problem with the legends in episode 8 as episode 7.

@ErinBecker
Copy link
Contributor Author

This PR is complete and ready to review. Would especially appreciate help with fixing the figure legend problem in episodes 7 and 8.

This was referenced Aug 2, 2018
Open
Closed
This was referenced Aug 2, 2018
Closed
Closed
@ErinBecker
Copy link
Contributor Author

I resolved merge conflicts after merging #232 and #231. Will merge this PR on @jsta's approval after checks complete.

@ErinBecker ErinBecker merged commit f2781af into datacarpentry:master Aug 13, 2018
@ErinBecker ErinBecker deleted the general-cleanup branch August 13, 2018 16:47
zkamvar pushed a commit that referenced this pull request Feb 7, 2023
@ErinBecker
Merge pull request #228 from ErinBecker/general-cleanup
8a0f3d0 
General cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsta jsta Awaiting requested review from jsta

@obrl-soil obrl-soil Awaiting requested review from obrl-soil

@r4space r4space Awaiting requested review from r4space

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert static plotting from base r to ggplot2
2 participants
@ErinBecker @r4space