Fix VerifyMembership proof #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
siburu
reviewed
Dec 21, 2023
Comment on lines
126
to
127
| heightBig.Or(revisionNumberBig, revisionHeightBig) | ||
| hashHeight := sha256.Sum256(heightBig.Bytes()) |
There was a problem hiding this comment.
There are two mistakes.
- Look at the spec again.
heightis concatenated to the other stuffs before hashing. - The byte length of
heightBig.Bytes()can be less than 16.- For example, if
revisionNumber == 0, it will be 8. - You should use
FillBytesinstead ofBytes.
- For example, if
There was a problem hiding this comment.
I think you can use encoding/binary to do this easilier.
https://pkg.go.dev/encoding/binary#example-ByteOrder-Put
There was a problem hiding this comment.
Thanks
Change to use encoding/binary
28f2d67
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
siburu
reviewed
Jan 30, 2024
There was a problem hiding this comment.
@dongrie Check the spec of Solidity's ABI encoding.
https://docs.soliditylang.org/en/latest/abi-spec.html
Comment on lines
123
to
124
| binary.LittleEndian.PutUint64(heightBuf[:8], revisionHeight) | ||
| binary.LittleEndian.PutUint64(heightBuf[8:], revisionNumber) |
There was a problem hiding this comment.
Please use BigEndian and put revisionNumber at first and revisionHeight at last.
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
siburu
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix verifyMembership Proof
https://github.com/hyperledger-labs/yui-ibc-solidity/blob/b3dc7b23bc849cb2bb0381d79016c97b93d5ccb5/tests/foundry/src/helpers/ModifiedMockClient.sol