Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make proof #129

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Fix make proof #129

merged 5 commits into from
Jan 31, 2024

Conversation

dongrie
Copy link
Contributor

@dongrie dongrie commented Dec 14, 2023

Fix make proof

ibc-mock-client
datachainlab/ibc-mock-client#11

@dongrie dongrie requested a review from a team as a code owner December 14, 2023 06:31
@@ -168,5 +168,6 @@ require (
replace (
// https://github.com/cosmos/cosmos-sdk/blob/v0.47.3/go.mod#L171-L182
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
github.com/datachainlab/ibc-mock-client => github.com/dongrie/ibc-mock-client v0.3.3-0.20231213015729-29b70e76baf2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datachainlab/ibc-mock-client#11
Once this PR is merged, we plan to switch to the new version.

provers/mock/prover.go Outdated Show resolved Hide resolved
@dongrie dongrie requested a review from siburu January 10, 2024 01:05
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
yui-relayer Outdated
Copy link
Contributor

@siburu siburu Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie Never commit this binary file.

Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
@dongrie dongrie requested a review from siburu January 31, 2024 02:21
@dongrie
Copy link
Contributor Author

dongrie commented Jan 31, 2024

@siburu changed it to use ibc-mock-client@v0.3.3

Signed-off-by: Dongri Jin <dongri.jin@speee.jp>
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie LGTM, thank you!

@siburu siburu merged commit bbea0d0 into hyperledger-labs:main Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants