Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add person_id to doi model #1049

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Dec 4, 2023

Purpose

Adds a person_id to the doi model

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
Copy link
Contributor Author

jrhoads commented Dec 4, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Dec 4, 2023
* Index person_id

* Add related_doi indexing (#1051)

* Add related_doi indexing

* Add relation_type to the hash

* Add more fields to the related_dois indexed info

* Add tests for related_dois

* Add related_dois to elasticsearch

* Appease Rubocop
@jrhoads jrhoads merged commit ad5b17c into master Dec 6, 2023
13 checks passed
@jrhoads jrhoads deleted the 11-30-Add_person_id_to_doi_model branch December 6, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants