Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for nil related_identifiers when indexing related_dois #1059

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Dec 7, 2023

Purpose

Related_identifiers may be nil. We need to makes sure we can handle this.

closes: #1058

Approach

Uses Array.Wrap to create an empty array if related_identifiers is nil.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
Copy link
Contributor Author

jrhoads commented Dec 7, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jrhoads jrhoads merged commit ddf5eb5 into master Dec 8, 2023
13 checks passed
@jrhoads jrhoads deleted the 12-07-Account_for_nil_related_identifiers_when_indexing_related_dois branch December 8, 2023 01:26
Copy link

sentry-io bot commented Dec 9, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **NoMethodError: undefined method fetch' for "":String** app/models/doi/indexer/related_doi_indexer.rb i...` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: private method `select' called for nil:NilClass
3 participants