-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to drop warnings for reference checks for properties with known Text values #66
Comments
I think we want measurementMethod to refer to entities so we can describe the method used, etc. Thus, I feel like this check as such is useful to have, and would also agree to removing Text from its rangeIncludes. Adding an option to ignore certains warnings is something we can do. Would we refer to the specific warning using counter name, like "Existence_MissingValueRef_measurementMethod" ? |
On Thu, 16 Sept 2021 at 07:24, Prashanth R ***@***.***> wrote:
I think we want measurementMethod to refer to entities so we can describe
the method used, etc. Thus, I feel like this check as such is useful to
have, and would also agree to removing Text from its rangeIncludes.
sg. measurementMethod has rangeIncludes Enum. Should we convert the
existing text ones into Enum? Is there a broader Enum for measurements?
Adding an option to remove warnings is something we can do. Would we refer
to the specific warning using counter name, like
"Existence_MissingValueRef_measurementMethod" ?
Yes, the counter name or a flag to skip reference check warnings for
specific new entities that are being added in a different change to the
schema.
Does the dc-import lint use APIs from the autopush or the prod?
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCZASMRZRLIKBOYXAXNBPTUCFE7DANCNFSM5EAICTAQ>
.
|
What's an example of existing text one? The infra I thought would treat mmethod value as a reference.
https://github.com/datacommonsorg/schema/blob/main/core/measurement_methods.mcf#L7-L11
It uses staging (to not impact prod). I've been considering using autopush to get most recent build, but the instance gets restarted on every code change, so was worried about reliability... |
Foe the un energy, I used UNStatsEstimate as the measurement method for a
subset of values marked as estimates in the input CSV.
I haven't defined this as an enum. I'll add this to the measurement method
enum you pointed.
…On Thu 16 Sep, 2021, 8:22 PM Prashanth R, ***@***.***> wrote:
Should we convert the existing text ones into Enum?
What's an example of existing text one? The infra I thought would treat
mmethod value as a reference.
Is there a broader Enum for measurements?
https://github.com/datacommonsorg/schema/blob/main/core/measurement_methods.mcf#L7-L11
Does the dc-import lint use APIs from the autopush or the prod?
It uses staging (to not impact prod). I've been considering using autopush
to get most recent build, but the instance gets restarted on every code
change, so was worried about reliability...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCZASJLLX5N3YBCJCBCMTTUCIAELANCNFSM5EAICTAQ>
.
|
The UNEnergy data set uses measurementMethod: UNStatsEstimate in the statVarObs mcf.
The dc-import generates a warning for this:
{
"level": "LEVEL_WARNING",
"location": {
"file": "un_energy_output.csv",
"lineNumber": "4"
},
"userMessage": "Failed existence check :: reference: 'UNStatsEstimate', property: 'measurementMethod', node: 'E:UNEnergy->E0'",
"counterKey": "Existence_MissingValueRef_measurementMethod"
},
measurementMethod allows Text in rangeIncludes
rangeIncludes: Text, Enumeration
Can we have a flag to ignore specific warnings such as reference checks for know values,
so we can easily catch other warnings/errors in the report.json?
The text was updated successfully, but these errors were encountered: