Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service sent as tag, rather than as an attribute #505

Closed
xepps opened this issue Aug 25, 2020 · 7 comments
Closed

Service sent as tag, rather than as an attribute #505

xepps opened this issue Aug 25, 2020 · 7 comments
Labels
enhancement New feature or request logs rum

Comments

@xepps
Copy link

xepps commented Aug 25, 2020

Hi

We have been using datadog for a while for our backend services, and recently went to introduce it to one of our new front end projects. We noticed that the service was being sent, but as a tag rather than as an attribute, which means it doesn't show as a service in the dashboard.

I had noticed that there was a recent pull request to fix this issue RUMF-620, but that this has been reverted in the latest release v.1.16.0.

Is this being planned for a separate release, or is actually "working as intended". Hopefully the former!

Thanks!

@xepps
Copy link
Author

xepps commented Aug 25, 2020

I see there is actually an open PR #501

Feel free to close this issue when you want. 👍

@pmc-a
Copy link

pmc-a commented Sep 9, 2020

@xepps did you manage to find a solution in the interim? I've tried remapping the tag to the attribute, but I'm not entirely sure if that's possible since service is a reserved attribute!

Thanks for highlighting this!

@pmc-a
Copy link

pmc-a commented Sep 9, 2020

I think I found a way to remap the service tag to a custom attribute, took the following steps in case anyone else comes across this in the future:

  • Add a new custom 'Standard Attribute' - e.g. client.application
  • Created a new 'Pipeline' with a filter targeting source:browser
  • Created a 'Remapper' processor which remaps the tag service to the new custom attribute client.application

I was then able to filter by this in the standard log explorer. Hopefully this helps anyone who comes up against the same issue!

@KarlKl
Copy link

KarlKl commented Sep 10, 2020

I'm using the datadog-logs.js v1.18.1 and it still doesn't work.
It worked in the NPM package v1.12.10 if it is specified in the global context, I don't know whether it works in newer npm package versions.

@bcaudan
Copy link
Contributor

bcaudan commented Sep 10, 2020

Hello,

There is in progress work to send service as a tag.
In the mean time, for logs, you can configure a remapper to set a service tag from the service attribute.

We'll ping here when it will be sent out of the box.

@bcaudan bcaudan added enhancement New feature or request logs rum labels Sep 10, 2020
@xepps
Copy link
Author

xepps commented Sep 15, 2020

Thanks @bcaudan. Looking forward to the update 👍

@xepps
Copy link
Author

xepps commented Oct 12, 2020

Looks to be resolved in v1.21.0 #543

Thanks all.

@xepps xepps closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logs rum
Projects
None yet
Development

No branches or pull requests

4 participants