Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.0 support, loosen version constraints #83

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

tony
Copy link

@tony tony commented Jan 5, 2022

Fixes #82

@tony
Copy link
Author

tony commented Feb 1, 2022

@datadvance Can you take a look at this PR for Django 4.0 support please?

@tony tony mentioned this pull request Feb 6, 2022
@Luferov
Copy link

Luferov commented Feb 19, 2022

@prokher could you check PR and accept. Thanks!

@tony
Copy link
Author

tony commented Feb 22, 2022

@datadvance Please give this a look if you can!

@danielknightgaynor
Copy link

@datadvance I'd also appreciate this being reviewed/merged 👍

pyproject.toml Outdated Show resolved Hide resolved
@tony tony changed the title Django 4.0 support Django 4.0 support, loosen version constraints May 24, 2022
@tony
Copy link
Author

tony commented May 24, 2022

@datadvance any possibility you could take a look?

@Luferov
Copy link

Luferov commented May 24, 2022

Hey, @tony create you own library from this and push it to pypi.

@helgihg
Copy link

helgihg commented Oct 28, 2022

Any news on when this could be merged? I've looked through the changes and they're not that complicated. Django 4.0 has been out for almost a year now and 4.1 is already out.

@Ronjea
Copy link

Ronjea commented Nov 2, 2022

It would be lovely to have this out as a package 🚀

@boomdizz
Copy link

Seeing these. Could someone provide an ETA for when support for the latest packages would be available?

django-channels-graphql-ws 0.9.1 requires channels<4,>=3, but you have channels 4.0.0 which is incompatible.
django-channels-graphql-ws 0.9.1 requires Django<4,>=3, but you have django 4.1.2 which is incompatible.
django-channels-graphql-ws 0.9.1 requires graphene<3.0,>=2.1, but you have graphene 3.1.1 which is incompatible.

@boomdizz
Copy link

boomdizz commented Feb 28, 2023

Another dependency that likely needs to be updated:

  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/__init__.py", line 29, in <module>
    from .client import GraphqlWsClient, GraphqlWsResponseError
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/client.py", line 30, in <module>
    from .transport import GraphqlWsTransport
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/transport.py", line 31, in <module>
    from . import graphql_ws_consumer
  File "<snipped>/lib/python3.10/site-packages/channels_graphql_ws/graphql_ws_consumer.py", line 57, in <module>
    import graphql.execution.executors.asyncio
ModuleNotFoundError: No module named 'graphql.execution.executors'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 4.0
9 participants