-
Notifications
You must be signed in to change notification settings - Fork 162
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#1214 [refactoring] load country-specific ID number providers by coun…
…try code Thus, we can add ID numbers for new countries just by implementing "IdNumbers" without need to add public methods like "validZhCNSsn()", "validEstonianPersonalCode()", "validBulgarianPersonalCode()" to class "IdNumber". Now all country-specific ID number generators are loaded from file "src/main/resources/META-INF/services/net.datafaker.idnumbers.IdNumbers" using a standard Java mechanism "service loader". + rename existing "*IdNumber" classes to human-readable, e.g. "ZhCnIdNumber" to "ChineseIdNumber".
- Loading branch information
Showing
45 changed files
with
611 additions
and
465 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ target | |
!.idea/icon.png | ||
*.iml | ||
/dependency-reduced-pom.xml | ||
META-INF/ | ||
bin/ | ||
site | ||
.mvn/wrapper/maven-wrapper.jar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/main/java/net/datafaker/idnumbers/AmericanIdNumber.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
package net.datafaker.idnumbers; | ||
|
||
import net.datafaker.providers.base.BaseProviders; | ||
|
||
import java.util.List; | ||
import java.util.regex.Pattern; | ||
|
||
public class AmericanIdNumber implements IdNumbers { | ||
@Override | ||
public String country() { | ||
return "US"; | ||
} | ||
|
||
private static final List<String> INVALID_SSNS = List.of( | ||
"0{3}-\\d{2}-\\d{4}", | ||
"\\d{3}-0{2}-\\d{4}", | ||
"\\d{3}-\\d{2}-0{4}", | ||
"666-\\d{2}-\\d{4}", | ||
"9\\d{2}-\\d{2}-\\d{4}"); | ||
|
||
private static final List<Pattern> INVALID_SSN_PATTERNS = INVALID_SSNS.stream() | ||
.map(Pattern::compile) | ||
.toList(); | ||
|
||
@Deprecated | ||
public String getValidSsn(BaseProviders f) { | ||
return generateValid(f); | ||
} | ||
|
||
@Override | ||
public String generateValid(BaseProviders f) { | ||
final String ssn = f.regexify("[0-8]\\d{2}-\\d{2}-\\d{4}"); | ||
|
||
boolean isValid = INVALID_SSN_PATTERNS.stream() | ||
.noneMatch(invalidSSNPattern -> invalidSSNPattern.matcher(ssn).matches()); | ||
return isValid ? ssn : generateValid(f); | ||
} | ||
|
||
@Override | ||
public String generateInvalid(BaseProviders faker) { | ||
return faker.regexify(faker.options().option(INVALID_SSNS)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 22 additions & 5 deletions
27
...net/datafaker/idnumbers/ZhCnIdNumber.java → .../datafaker/idnumbers/ChineseIdNumber.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/main/java/net/datafaker/idnumbers/GeorgianIdNumber.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package net.datafaker.idnumbers; | ||
|
||
import net.datafaker.providers.base.BaseProviders; | ||
|
||
/** | ||
* Generates ID numbers for Georgian citizens and Residents | ||
*/ | ||
public class GeorgianIdNumber implements IdNumbers { | ||
@Override | ||
public String country() { | ||
return "GE"; | ||
} | ||
|
||
@Override | ||
public String generateValid(BaseProviders faker) { | ||
return faker.numerify("###########"); | ||
} | ||
|
||
@Override | ||
public String generateInvalid(BaseProviders faker) { | ||
return faker.numerify("###########42"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,24 @@ | ||
package net.datafaker.idnumbers; | ||
|
||
import net.datafaker.providers.base.BaseProviders; | ||
|
||
import java.time.format.DateTimeFormatter; | ||
|
||
public interface IdNumbers { | ||
DateTimeFormatter DATE_TIME_FORMATTER = DateTimeFormatter.ofPattern("yyMMdd"); | ||
|
||
/** | ||
* @return ISO-2 code of the country ("US" for America, "EE" for Estonia etc.) | ||
*/ | ||
String country(); | ||
|
||
/** | ||
* Generates a valid ID number for given country (a.k.a. "SSN", "Personal code" etc.) | ||
*/ | ||
String generateValid(BaseProviders faker); | ||
|
||
/** | ||
* Generates an invalid ID number for given country (a.k.a. "SSN", "Personal code" etc.) | ||
*/ | ||
String generateInvalid(BaseProviders faker); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.