Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phone number formats for en-GB #274

Merged
merged 1 commit into from Aug 23, 2022

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Aug 4, 2022

Issue: #163
Minimized error code to +-10

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #274 (19737b5) into master (94d9955) will increase coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
+ Coverage     94.26%   94.68%   +0.41%     
- Complexity     1881     1892      +11     
============================================
  Files           195      195              
  Lines          3819     3819              
  Branches        391      391              
============================================
+ Hits           3600     3616      +16     
+ Misses          117      103      -14     
+ Partials        102      100       -2     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.92% <0.00%> (+0.60%) ⬆️
src/main/java/net/datafaker/Internet.java 90.41% <0.00%> (+1.36%) ⬆️
src/main/java/net/datafaker/Address.java 97.14% <0.00%> (+2.85%) ⬆️
src/main/java/net/datafaker/Commerce.java 100.00% <0.00%> (+4.00%) ⬆️
src/main/java/net/datafaker/IdNumber.java 100.00% <0.00%> (+6.66%) ⬆️
src/main/java/net/datafaker/Lorem.java 97.91% <0.00%> (+8.33%) ⬆️
...ava/net/datafaker/HitchhikersGuideToTheGalaxy.java 100.00% <0.00%> (+11.11%) ⬆️
src/main/java/net/datafaker/OscarMovie.java 100.00% <0.00%> (+16.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Aug 4, 2022

@snuyanzin seems the concurrent tests are still flaky

@snuyanzin
Copy link
Collaborator

looks like i forgot one field
currently playing with #275
in case it will not fail after a bunch of runs i'll merge it

@bodiam bodiam merged commit 59a288e into datafaker-net:master Aug 23, 2022
@panilya panilya deleted the fix-en_GB-phone-number-formats branch August 23, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants