Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3x times speed up Aws#route53ZoneId by moving textConfig in Aws to class field #532

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

snuyanzin
Copy link
Collaborator

Speed up net.datafaker.providers.base.Aws#route53ZoneId by moving textconfig to a class field
before

Benchmark                              Mode  Cnt     Score    Error   Units
DatafakerSimpleMethods.route53ZoneId  thrpt   10  1318.496 ± 11.038  ops/ms

after

Benchmark                              Mode  Cnt     Score     Error   Units
DatafakerSimpleMethods.route53ZoneId  thrpt   10  3636.202 ± 547.198  ops/ms

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #532 (b1ba66c) into main (ac4ba2e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #532   +/-   ##
=========================================
  Coverage     91.91%   91.91%           
  Complexity     2358     2358           
=========================================
  Files           247      247           
  Lines          4947     4948    +1     
  Branches        530      530           
=========================================
+ Hits           4547     4548    +1     
  Misses          272      272           
  Partials        128      128           
Impacted Files Coverage Δ
...rc/main/java/net/datafaker/providers/base/Aws.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 2d6ebd5 into datafaker-net:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants