Skip to content

3x times speed up Aws#route53ZoneId by moving textConfig in Aws to class field#532

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:awst
Nov 6, 2022
Merged

3x times speed up Aws#route53ZoneId by moving textConfig in Aws to class field#532
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:awst

Conversation

@snuyanzin
Copy link
Copy Markdown
Collaborator

Speed up net.datafaker.providers.base.Aws#route53ZoneId by moving textconfig to a class field
before

Benchmark                              Mode  Cnt     Score    Error   Units
DatafakerSimpleMethods.route53ZoneId  thrpt   10  1318.496 ± 11.038  ops/ms

after

Benchmark                              Mode  Cnt     Score     Error   Units
DatafakerSimpleMethods.route53ZoneId  thrpt   10  3636.202 ± 547.198  ops/ms

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 6, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (ac4ba2e) to head (b1ba66c).
Report is 1199 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #532   +/-   ##
=========================================
  Coverage     91.91%   91.91%           
  Complexity     2358     2358           
=========================================
  Files           247      247           
  Lines          4947     4948    +1     
  Branches        530      530           
=========================================
+ Hits           4547     4548    +1     
  Misses          272      272           
  Partials        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snuyanzin snuyanzin merged commit 2d6ebd5 into datafaker-net:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants