Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up text generation, remove faker from text config builder #534

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

snuyanzin
Copy link
Collaborator

Caching of text configs brings about 20% of speed
before

Benchmark                                         Mode  Cnt     Score    Error   Units
DatafakerPassword.password10                     thrpt   10  1293.016 ± 38.115  ops/ms
DatafakerPassword.password10WithUpper            thrpt   10  1059.780 ± 83.480  ops/ms
DatafakerPassword.password10WithUpperLower       thrpt   10   963.004 ± 79.944  ops/ms
DatafakerPassword.password10WithUpperLowerDigit  thrpt   10   992.366 ± 32.792  ops/ms

after


Benchmark                                         Mode  Cnt     Score     Error   Units
DatafakerPassword.password10                     thrpt   10  1577.841 ± 112.689  ops/ms
DatafakerPassword.password10WithUpper            thrpt   10  1262.548 ±  74.436  ops/ms
DatafakerPassword.password10WithUpperLower       thrpt   10  1212.872 ±  27.308  ops/ms
DatafakerPassword.password10WithUpperLowerDigit  thrpt   10  1203.032 ±  45.527  ops/ms

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #534 (75ce64f) into main (fae5694) will decrease coverage by 0.17%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main     #534      +/-   ##
============================================
- Coverage     91.91%   91.74%   -0.18%     
+ Complexity     2359     2355       -4     
============================================
  Files           247      247              
  Lines          4949     4953       +4     
  Branches        530      530              
============================================
- Hits           4549     4544       -5     
- Misses          272      279       +7     
- Partials        128      130       +2     
Impacted Files Coverage Δ
...c/main/java/net/datafaker/providers/base/Text.java 68.88% <82.14%> (+2.22%) ⬆️
...rc/main/java/net/datafaker/providers/base/Aws.java 100.00% <100.00%> (ø)
...in/java/net/datafaker/providers/base/Internet.java 91.77% <100.00%> (-0.40%) ⬇️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 86.02% <0.00%> (-0.87%) ⬇️
.../datafaker/transformations/sql/SqlTransformer.java 86.29% <0.00%> (-0.75%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 9974c4f into datafaker-net:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants