Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CreditCardType to an internal class. Cleaned up a few Qodana wa… #786

Merged
merged 1 commit into from Apr 23, 2023

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Apr 23, 2023

…rnings, and fixed Qodana URL.

@what-the-diff
Copy link

what-the-diff bot commented Apr 23, 2023

PR Summary

  • Update badge link in README.md
    Improve the visibility of the project's status by updating the badge link in the main documentation file.
  • Optimize StringBuilder usage
    Improve efficiency by using a recommended method for appending strings.
  • Relocate and rename FakerIDN class
    Organize the codebase by moving the FakerIDN class to a more appropriate location and updating references.
  • Add missing CreditCardType to Finance provider
    Enhance the functionality of the Finance provider by adding a missing credit card type enum.
  • Remove unused import statement
    Clean up the code by removing an unnecessary import statement.
  • Use constant for building Twitter text and links
    Improve code readability and maintainability by using a constant variable for frequently-used strings.

@codecov-commenter
Copy link

Codecov Report

Merging #786 (807ba5b) into main (3d4c572) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #786      +/-   ##
============================================
- Coverage     92.89%   92.84%   -0.06%     
  Complexity     2641     2641              
============================================
  Files           285      284       -1     
  Lines          5211     5211              
  Branches        537      537              
============================================
- Hits           4841     4838       -3     
- Misses          242      245       +3     
  Partials        128      128              
Impacted Files Coverage Δ
...n/java/net/datafaker/internal/helper/FakerIDN.java 90.90% <ø> (ø)
...ain/java/net/datafaker/providers/base/Company.java 97.22% <ø> (ø)
...in/java/net/datafaker/providers/base/Internet.java 91.66% <ø> (ø)
.../main/java/net/datafaker/idnumbers/NricNumber.java 95.65% <100.00%> (ø)
...ain/java/net/datafaker/idnumbers/ZhCnIdNumber.java 95.74% <100.00%> (ø)
...net/datafaker/internal/helper/SingletonLocale.java 76.19% <100.00%> (+1.19%) ⬆️
...ain/java/net/datafaker/providers/base/Finance.java 98.64% <100.00%> (+0.11%) ⬆️
...ain/java/net/datafaker/providers/base/Twitter.java 85.93% <100.00%> (-0.22%) ⬇️
...net/datafaker/transformations/JsonTransformer.java 94.91% <100.00%> (ø)
.../net/datafaker/transformations/XmlTransformer.java 91.76% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam bodiam merged commit eb2892d into main Apr 23, 2023
8 checks passed
@kingthorin kingthorin deleted the cleanups branch April 23, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants