Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shading for generex and automaton #797

Merged
merged 1 commit into from Apr 30, 2023

Conversation

snuyanzin
Copy link
Collaborator

It seems these 2 were missed

to double check the whole list of libs that are used during runtime and should and shaded this command could be used

mvn dependency:tree | grep compile

output

[INFO] +- org.yaml:snakeyaml:jar:2.0:compile
[INFO] +- com.github.mifmif:generex:jar:1.0.2:compile
[INFO] |  \- dk.brics.automaton:automaton:jar:1.11-8:compile

@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

PR Summary

  • Added new dependencies: generex and automaton
    These new dependencies provide additional functionality for the project and help improve its performance.

  • Shaded libraries to avoid conflicts
    By shading the three libraries, we reduce the risk of version conflicts with other libraries in the project, ensuring smooth operation and compatibility.

@snuyanzin
Copy link
Collaborator Author

// cc @bodiam

@codecov-commenter
Copy link

Codecov Report

Merging #797 (299bee7) into main (e5b204b) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #797      +/-   ##
============================================
- Coverage     92.54%   92.49%   -0.06%     
+ Complexity     2654     2652       -2     
============================================
  Files           286      286              
  Lines          5275     5275              
  Branches        553      553              
============================================
- Hits           4882     4879       -3     
- Misses          252      253       +1     
- Partials        141      143       +2     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -241,6 +241,8 @@
<artifactSet>
<includes>
<include>org.yaml:snakeyaml:*:*</include>
<include>com.github.mifmif:generex:*:*</include>
<include>dk.brics.automaton:automaton:*:*</include>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just include all dependencies? It's unlikely we'll add more perhaps, but if we would, we'd need to remember to update this too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway you need to update relocation part individually , so it will not solve the issue

@snuyanzin snuyanzin merged commit 09e4d90 into datafaker-net:main Apr 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants