Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shading for generex and automaton #797

Merged
merged 1 commit into from Apr 30, 2023
Merged

Add shading for generex and automaton #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions pom.xml
View file
Open in desktop
Expand Up @@ -241,6 +241,8 @@
<artifactSet>
<includes>
<include>org.yaml:snakeyaml:*:*</include>
<include>com.github.mifmif:generex:*:*</include>
<include>dk.brics.automaton:automaton:*:*</include>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just include all dependencies? It's unlikely we'll add more perhaps, but if we would, we'd need to remember to update this too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway you need to update relocation part individually , so it will not solve the issue

</includes>
</artifactSet>
<filters>
Expand All @@ -256,6 +258,14 @@
<pattern>org.yaml.snakeyaml</pattern>
<shadedPattern>net.datafaker.shaded.snakeyaml</shadedPattern>
</relocation>
<relocation>
<pattern>com.mifmif.common.regex</pattern>
<shadedPattern>net.datafaker.shaded.generex</shadedPattern>
</relocation>
<relocation>
<pattern>dk.brics.automaton</pattern>
<shadedPattern>net.datafaker.shaded.automaton</shadedPattern>
</relocation>
</relocations>
</configuration>
<executions>
Expand Down