Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue --dbt diff when null PKs exist #585

Merged
merged 4 commits into from May 18, 2023
Merged

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented May 17, 2023

Adds a skip_null_keys option to joindiff (default False)

When set to True, instead of throwing an error and exiting the diff, a warning is displayed and the diff continues (row is skipped).

Added for --dbt diffs to resolve #527
Screenshot 2023-05-17 at 4 21 01 PM

@dlawin dlawin added bug Something isn't working enhancement New feature or request --dbt Issues/features related to the dbt integration labels May 17, 2023
@dlawin dlawin self-assigned this May 17, 2023
@dlawin dlawin merged commit 9ffb136 into datafold:master May 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--dbt Issues/features related to the dbt integration bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seemingly incorrect "ValueError: Duplicate primary keys" error
2 participants