Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Support missing dbt connection attributes aliases #690

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

sar009
Copy link
Contributor

@sar009 sar009 commented Aug 25, 2023

Supporting missing dbt connection attribute aliases.

Fixing #689

Signed-off-by: Sarad Mohanan <sarad.mohanan@gmail.com>
Copy link
Contributor

@sungchun12 sungchun12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests where these new attributes get called in the respective profiles.yml and work as expected?

@sar009

@dlawin
Copy link
Contributor

dlawin commented Sep 25, 2023

Can you add tests where these new attributes get called in the respective profiles.yml and work as expected?

@sar009

I think we can go ahead and merge it

@dlawin dlawin requested a review from sungchun12 October 9, 2023 18:18
@sungchun12
Copy link
Contributor

I don't see regression risks here anymore.

@sungchun12 sungchun12 merged commit 435e7c0 into datafold:master Oct 9, 2023
6 checks passed
sungchun12 pushed a commit that referenced this pull request Oct 10, 2023
Signed-off-by: Sarad Mohanan <sarad.mohanan@gmail.com>
Co-authored-by: Dan Lawin <daniel@datafold.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants