Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Bigquery dbt impersonation #715

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Bigquery dbt impersonation #715

merged 9 commits into from
Oct 13, 2023

Conversation

ivan-toriya
Copy link
Contributor

@dlawin dlawin requested review from dlawin and nolar September 25, 2023 21:17
@dlawin
Copy link
Contributor

dlawin commented Sep 25, 2023

This looks great @ivan-toriya, really appreciate the contribution!

There's a restructuring of some of the /sqeleton code going on. I'm thinking of merging this after that goes through so we can handle this merge conflicts in this PR cc: @nolar

@dlawin
Copy link
Contributor

dlawin commented Oct 9, 2023

@ivan-toriya can you look at the merge conflicts and we'll get this merged?

I'll set a reminder for later this week if you're not able to get to it

@dlawin dlawin linked an issue Oct 9, 2023 that may be closed by this pull request
The impersonate_service_account for oauth BigQuery method not working #693
Closed
dlawin
dlawin reviewed Oct 13, 2023
View reviewed changes
data_diff/dbt_parser.py Outdated Show resolved Hide resolved
@dlawin dlawin merged commit 800aa1b into datafold:master Oct 13, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlawin dlawin dlawin approved these changes

@nolar nolar Awaiting requested review from nolar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The impersonate_service_account for oauth BigQuery method not working
2 participants
@ivan-toriya @dlawin