Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Block merge on formatter error #768

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented Nov 3, 2023

Currently, review dog will add suggestions, but the step is always green. Update to fail the CI job on bad formatting

data_diff/diff_tables.py Outdated Show resolved Hide resolved
@dlawin dlawin force-pushed the block_merge_on_bad_formatting branch from 6286e6f to 22fe539 Compare November 3, 2023 22:02
@dlawin dlawin changed the title test blocking merge on formatter error Block merge on formatter error Nov 3, 2023
@dlawin dlawin self-assigned this Nov 3, 2023
@sungchun12 sungchun12 merged commit 886a615 into master Nov 4, 2023
6 checks passed
@sungchun12 sungchun12 deleted the block_merge_on_bad_formatting branch November 4, 2023 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants