This repository has been archived by the owner on May 17, 2024. It is now read-only.
tracking should be optional in dbt configuration #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungchun12
force-pushed
the
optional-user
branch
from
8fec9c5
to
7fb483a
Compare
sungchun12
reviewed
Nov 4, 2023
|
Thanks for this and your first time contributing to |
sungchun12
approved these changes
Nov 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #750, which is caused from the dbt config validator requiring
user_id(as well asproject_id). These can be null when anonymous tracking is disabled. The rest of the code treats this as optional, so the fix is just addressing the type in the pydantic model. I added a new flavor of a v11 manifest for testing, and verified that this test failed with the previous code but succeeds with the new code. This is an identical copy to v11.json but hasproject_name,project_id, anduser_idremoved, andsend_anonymous_usage_statsset to null. I also verified that I could now run data-diff on the original project where it was failing.Note that I couldn't get a completely clean test run due to some issues parsing dbt profiles that I posted about in the slack channel. However, those errors were present on the trunk code prior to the change.