Make local dbt data diffs concurrent #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 13, 2023 11:19
…eature/concurrent-dbt-diffs
…eature/concurrent-dbt-diffs
dlawin
reviewed
Nov 17, 2023
|
Resolves #426 |
Closed
added 8 commits
November 17, 2023 16:20
sungchun12
commented
Nov 20, 2023
added 4 commits
November 20, 2023 17:22
…eature/concurrent-dbt-diffs
…eature/concurrent-dbt-diffs
dlawin
reviewed
Dec 5, 2023
dlawin
approved these changes
Dec 5, 2023
Co-authored-by: Dan Lawin <daniel@datafold.com>
sungchun12
commented
Dec 5, 2023
sungchun12
commented
Dec 5, 2023
sungchun12
commented
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the midst of working on #770, I realized all local dbt data diffs run sequentially. This makes data-diff run slower than necessary to reach the same results. Race conditions shouldn't be an issue because each query
data-diffruns are independent by design. This is also validated by the fact that cloud data diffs have concurrent diffs already built for awhile and have not encountered bugs.ThreadPoolExecutorfor cloud diffs and local diffsBefore this PR: Sequential performance is slow
After this PR: Consistently get 2-4x performance increase with concurrency enabled
data-diff PR Demo V1 - Watch Video
Verify Concurrent Data Diffs work with VS Code Extension - Watch Video