Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace emojione #20

Closed
mcfiredrill opened this issue Feb 16, 2017 · 4 comments
Closed

replace emojione #20

mcfiredrill opened this issue Feb 16, 2017 · 4 comments

Comments

@mcfiredrill
Copy link
Member

mcfiredrill commented Feb 16, 2017

If there was something that just used the normal system emoji images, with fallback to images, I think it would be better.

hergaiety pushed a commit to hergaiety/datafruits that referenced this issue Feb 5, 2020
@dudethatbe
Copy link
Contributor

how do we still feel about this? i think it adds to odd appeal of the site that we have some outdated emoji set that no one uses anymore. If anything, I'd like to have an emoji selection menu that displays all of these (like in discord or other chat dealies)

@mcfiredrill
Copy link
Member Author

I'm not sure how I feel, it does feel kind of part of the site now that its been around so long.

If there's any bugs in it I'm not sure how we will upgrade, I forked it a long time ago to add custom emoji and haven't incorporated any upstream changes since.
https://github.com/mcfiredrill/emojione#animated-emoji

I guess the project isn't even called emojione anymore.
https://emojipedia.org/joypixels/

@dudethatbe
Copy link
Contributor

If there were any serious bugs in it, I'd think they would have surfaced by now. Maybe something will break in the future, but it seems to me that it has been working just fine. I'd be inclined to close this and revisit the issue if emojione causes any issues.

@mcfiredrill
Copy link
Member Author

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants