Add formatting to eslint #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2020 23:15
Integrated prettier with eslint to enforce commit code styling.
Listen I know a ton of files changed but i swear it's literally all formatting. Tests still passed so hopefully it's fine 😅
mcfiredrill
reviewed
Jul 2, 2020
|
This looks good, I'll have to setup my editor to run prettier as well. 👍 Looks like most of the changes are just changing to singlequotes. |
|
yeah, it's probably worth looking through all the options and figuring out what you'd like to use for the project -- i personally like trailing commas and single quotes, but otherwise don't have too many opinions |
|
Something wrong here? I was planning on reviewing this eventually, sorry just haven't got around to it yet. 😅 |
|
Nothing wrong lol I just was trying to get my fork's master to match the upstream master and in a fit of git-induced rage i deleted every branch 🙃 |
|
Here's a link for anyone else using vim and coc: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use prettier and eslint-plugin-prettier to enforce consistent formatting across the project.
yarn lint:js --fixwill automatically fix formatting errors wherever possible. Usually, it's also possible to configure your text editor to automatically fix on save a la prettier-vscode.I configured
.prettierrcwith some of the defaults i like, but you're more than welcome to change them if you don't like them. The full configuration options are here.There are a shit ton of files changed but I swear I only ran prettier. The first commit is just me configuring the formatter if you're looking for what I actually did.