Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix add column update bug #10037

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Feb 14, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. fix: fix add column update bug
  2. rename some miss used name from column idx to column index
  3. unit test for this bug.

Closes #9938

@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 14, 2023 at 2:57PM (UTC)

@lichuang lichuang requested a review from zhyass February 14, 2023 08:52
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Feb 14, 2023
@BohuTANG
Copy link
Member

--- /workspace/tests/suites/0_stateless/17_altertable/17_0003_alter_table_update.result	2023-02-14 09:29:48.315995269 +0000
+++ /workspace/tests/suites/0_stateless/17_altertable/17_0003_alter_table_update.stdout	2023-02-14 09:34:58.534629243 +0000
@@ -1,9 +1,7 @@
 alter table add a column
 update table column
-ERROR 1105 (HY000) at line 1: Code: 1104, displayText = index out of bounds: the len is 2 but the index is 2.
 alter table drop a column
 update table column
-ERROR 1105 (HY000) at line 1: Code: 1104, displayText = index out of bounds: the len is 0 but the index is 0.
 alter table add a column
 update table column
 alter table drop a column

Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit ef89128 into datafuselabs:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: update/delete error after alter table add column
3 participants