Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function):GREATEST and LEAST function #13075

Merged
merged 76 commits into from
Oct 11, 2023

Conversation

zenus
Copy link
Contributor

@zenus zenus commented Sep 30, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR


This change is Reviewable

@vercel
Copy link

vercel bot commented Sep 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 9:51am

@zenus zenus marked this pull request as ready for review October 1, 2023 10:42
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 1, 2023
@b41sh b41sh changed the title feat(function):GREATEST function feat(function):GREATEST and LEAST function Oct 9, 2023
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit be202c9 into datafuselabs:main Oct 11, 2023
56 of 61 checks passed
@BohuTANG
Copy link
Member

@zenus Thanks for the contribution!

cc @soyeric128 for the doc.

andylokandy added a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* fix bug: full outer join with string_agg function panic

* fix bug: full outer join with string_agg function panic

* fix bug: full outer join with string_agg function panic

* add test case

* optimized

* optimized

* optimiezed

* optimize

* feat:greatest

* fixed

* add unit test

* fixed

* optimized

* optimized

* add unit test

* fixed

* fixed

* fixed

* optimized

* test

* test

* fixed

* fixed

* fixed

* add test case

* fix test case

* add test

* fix test

* add debug info

* fiex module test

* fix nullable

* fix nullable return_type

* add null return_type

* fixed

* fixed test case

* add test case

* fixed clone error

* add test case

* add test case

* remove convert type

* fixed

* remove type

* clean code

* clean code

* optimized

* Update src/query/sql/src/planner/semantic/type_check.rs

Co-authored-by: Andy Lok <andylokandy@hotmail.com>

* Update src/query/sql/src/planner/semantic/type_check.rs

Co-authored-by: Andy Lok <andylokandy@hotmail.com>

* fixed

* add greatest

* add def

* Update other.rs

* Update other.txt

* Update 02_0066_function_greatest

* add least function

* fix test

* Update other.rs

* Update other.rs

* Update other.rs

---------

Co-authored-by: Andy Lok <andylokandy@hotmail.com>
Co-authored-by: BohuTANG <overred.shuttler@gmail.com>
Co-authored-by: sundyli <543950155@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: GREATEST function
5 participants