-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(function):GREATEST and LEAST function #13075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Oct 1, 2023
b41sh
reviewed
Oct 8, 2023
b41sh
reviewed
Oct 9, 2023
b41sh
changed the title
feat(function):GREATEST function
feat(function):GREATEST and LEAST function
Oct 9, 2023
andylokandy
reviewed
Oct 9, 2023
b41sh
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andylokandy
approved these changes
Oct 10, 2023
@zenus Thanks for the contribution! cc @soyeric128 for the doc. |
andylokandy
added a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* fix bug: full outer join with string_agg function panic * fix bug: full outer join with string_agg function panic * fix bug: full outer join with string_agg function panic * add test case * optimized * optimized * optimiezed * optimize * feat:greatest * fixed * add unit test * fixed * optimized * optimized * add unit test * fixed * fixed * fixed * optimized * test * test * fixed * fixed * fixed * add test case * fix test case * add test * fix test * add debug info * fiex module test * fix nullable * fix nullable return_type * add null return_type * fixed * fixed test case * add test case * fixed clone error * add test case * add test case * remove convert type * fixed * remove type * clean code * clean code * optimized * Update src/query/sql/src/planner/semantic/type_check.rs Co-authored-by: Andy Lok <andylokandy@hotmail.com> * Update src/query/sql/src/planner/semantic/type_check.rs Co-authored-by: Andy Lok <andylokandy@hotmail.com> * fixed * add greatest * add def * Update other.rs * Update other.txt * Update 02_0066_function_greatest * add least function * fix test * Update other.rs * Update other.rs * Update other.rs --------- Co-authored-by: Andy Lok <andylokandy@hotmail.com> Co-authored-by: BohuTANG <overred.shuttler@gmail.com> Co-authored-by: sundyli <543950155@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
This change is