Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] remove query binary dependencies and add more precheck for local cluster #2417

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Oct 24, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

image

Changelog

  • Improvement

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #2417 (1174419) into main (7ac628f) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2417    +/-   ##
======================================
  Coverage     71%     71%            
======================================
  Files        641     641            
  Lines      36109   36236   +127     
======================================
+ Hits       25766   25965   +199     
+ Misses     10343   10271    -72     
Impacted Files Coverage Δ
metasrv/src/api/http_service.rs 14% <0%> (-62%) ⬇️
query/src/common/mod.rs 72% <0%> (-18%) ⬇️
metasrv/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
cli/src/error.rs 24% <0%> (-2%) ⬇️
query/src/clusters/cluster.rs 59% <0%> (-2%) ⬇️
query/src/datasources/index/range_filter.rs 90% <0%> (-2%) ⬇️
metasrv/src/meta_service/meta_service_impl.rs 71% <0%> (-2%) ⬇️
...unctions/src/aggregates/aggregate_function_test.rs 87% <0%> (-1%) ⬇️
query/src/pipelines/transforms/transform_source.rs 72% <0%> (-1%) ⬇️
query/src/catalogs/table.rs 72% <0%> (-1%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac628f...1174419. Read the comment docs.

@ZhiHanZ ZhiHanZ requested a review from BohuTANG October 25, 2021 01:26
@BohuTANG
Copy link
Member

/lgtm
Cool

@databend-bot
Copy link
Member

Approved! Thank you for the PR @ZhiHanZ

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit c589b8a into datafuselabs:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants