-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-2460: use non-block reading in async methods of fuse tbl #2485
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov Report
@@ Coverage Diff @@
## main #2485 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 643 643
Lines 36541 36552 +11
=====================================
+ Hits 26362 26372 +10
- Misses 10179 10180 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the reasons for why still need deep investigation.
CI Passed |
yeah, I am digging into it. touch you later |
/lgtm With a unit test it's getting better. |
Approved! Thank you for the PR @dantengsky |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
fix issue
async methods of fuse table should use async readers if possible
Changelog
Related Issues
Fixes #2460
Test Plan
Unit Tests
Stateless Tests