Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-2460: use non-block reading in async methods of fuse tbl #2485

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Oct 28, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

fix issue

async methods of fuse table should use async readers if possible

Changelog

  • Bug Fix
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #2460

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added pr-bugfix this PR patches a bug in codebase pr-not-for-changelog labels Oct 28, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

Codecov Report

Merging #2485 (edc2780) into main (f09aa2f) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2485   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        643     643           
  Lines      36541   36552   +11     
=====================================
+ Hits       26362   26372   +10     
- Misses     10179   10180    +1     
Impacted Files Coverage Δ
query/src/datasources/table/fuse/table.rs 90% <100%> (+<1%) ⬆️
...uery/src/datasources/table/fuse/table_do_append.rs 91% <100%> (+8%) ⬆️
...datasources/table/fuse/table_do_read_partitions.rs 92% <100%> (+<1%) ⬆️
...ry/src/datasources/table/fuse/table_do_truncate.rs 86% <100%> (ø)
query/src/common/mod.rs 69% <0%> (-21%) ⬇️
metasrv/src/meta_service/meta_service_impl.rs 70% <0%> (-2%) ⬇️
common/clickhouse-srv/src/types/block/mod.rs 96% <0%> (+<1%) ⬆️
query/src/datasources/table/fuse/index/min_max.rs 92% <0%> (+1%) ⬆️
common/datavalues/src/data_value_ops.rs 44% <0%> (+4%) ⬆️
common/streams/src/stream_progress.rs 95% <0%> (+4%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09aa2f...edc2780. Read the comment docs.

Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the reasons for why still need deep investigation.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit a5f802d into datafuselabs:main Oct 28, 2021
@dantengsky
Copy link
Member Author

LGTM, but the reasons for why still need deep investigation.

yeah, I am digging into it. touch you later

@drmingdrmer
Copy link
Member

/lgtm

With a unit test it's getting better.

@databend-bot
Copy link
Member

Approved! Thank you for the PR @dantengsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuse Engine hang in the second insert query
5 participants