Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-2784: Add tuple expression support #2785

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 14, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Tuple expression
e.g. (foo, bar)

Changelog

  • Improvement

Related Issues

Fixes #2784

Test Plan

Unit Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #2785 (274260d) into main (8d541a9) will decrease coverage by 0%.
The diff coverage is 84%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2785    +/-   ##
======================================
- Coverage     69%     69%    -1%     
======================================
  Files        601     599     -2     
  Lines      32728   32297   -431     
======================================
- Hits       22848   22385   -463     
- Misses      9880    9912    +32     
Impacted Files Coverage Δ
common/functions/src/scalars/function_factory.rs 92% <ø> (ø)
common/planners/src/plan_expression.rs 78% <ø> (ø)
common/functions/src/scalars/tuples/tuple_class.rs 75% <75%> (ø)
common/functions/src/scalars/tuples/tuple.rs 79% <79%> (ø)
common/datavalues/src/types/data_type.rs 64% <100%> (+1%) ⬆️
...mon/functions/src/scalars/nullables/is_not_null.rs 85% <100%> (ø)
common/functions/src/scalars/nullables/is_null.rs 85% <100%> (ø)
query/src/sql/plan_parser.rs 74% <100%> (-2%) ⬇️
common/meta/types/src/user_quota.rs 20% <0%> (-60%) ⬇️
metasrv/src/api/http_service.rs 8% <0%> (-55%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d541a9...274260d. Read the comment docs.

Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool and useful feature

@databend-bot
Copy link
Member

Wait for another reviewer approval

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @zhyass

@databend-bot databend-bot merged commit 4b94999 into datafuselabs:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] support tuple expression
5 participants