Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monotonicity check for some functions #3134

Merged
merged 4 commits into from Nov 30, 2021

Conversation

junli1026
Copy link
Contributor

@junli1026 junli1026 commented Nov 27, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

After #3009 is checked in, functions as follows need to have monotonic checking:

  1. arithmetic div
  2. arithmetic mul
  3. date number functions
  4. week date funcction
  5. floor
  6. ceil
  7. sign

Changelog

  • Improvement

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #3134 (a4afc16) into main (79cc5cc) will increase coverage by 0%.
The diff coverage is 77%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #3134    +/-   ##
======================================
  Coverage     66%     66%            
======================================
  Files        673     673            
  Lines      35108   35388   +280     
======================================
+ Hits       23430   23621   +191     
- Misses     11678   11767    +89     
Impacted Files Coverage Δ
...n/functions/src/scalars/dates/interval_function.rs 74% <0%> (ø)
...mon/functions/src/scalars/dates/number_function.rs 66% <0%> (-2%) ⬇️
common/functions/src/scalars/dates/week_date.rs 6% <0%> (-1%) ⬇️
common/functions/src/scalars/maths/ceil.rs 52% <0%> (-5%) ⬇️
common/functions/src/scalars/maths/floor.rs 52% <0%> (-5%) ⬇️
common/functions/src/scalars/maths/sign.rs 39% <0%> (-14%) ⬇️
...unctions/src/scalars/arithmetics/arithmetic_mul.rs 68% <65%> (-2%) ⬇️
query/src/optimizers/utils.rs 87% <69%> (-6%) ⬇️
common/functions/src/scalars/function.rs 66% <74%> (+24%) ⬆️
query/src/optimizers/utils_test.rs 90% <92%> (-1%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79cc5cc...a4afc16. Read the comment docs.

@junli1026 junli1026 force-pushed the jun/dev branch 2 times, most recently from ba00067 to 4e5a17a Compare November 28, 2021 00:34
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@junli1026 junli1026 force-pushed the jun/dev branch 3 times, most recently from 6dacb28 to 3da1205 Compare November 29, 2021 00:26
@junli1026 junli1026 marked this pull request as ready for review November 29, 2021 00:26
@junli1026
Copy link
Contributor Author

@zhyass could you please help to take a look ?

@junli1026 junli1026 force-pushed the jun/dev branch 4 times, most recently from fd36561 to f977299 Compare November 30, 2021 06:54
@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@BohuTANG
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

update

✅ Branch has been successfully updated

@zhyass
Copy link
Member

zhyass commented Nov 30, 2021

/lgtm

@BohuTANG BohuTANG merged commit 8cfeaf4 into datafuselabs:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants