Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length() function implementation #3448

Merged

Conversation

zenmiao7
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Implement Length() function

Changelog

  • New Feature

Related Issues

#3049

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Dec 13, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/6Yk7u2pL9nAZGXyXK3kqtuSvzhL1
✅ Preview: https://databend-git-fork-blacksmith96-u-blacksmith96le-0300a9-databend.vercel.app

[Deployment for 90da30a canceled]

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #3448 (2a35c41) into main (1f29cfc) will increase coverage by 0%.
The diff coverage is 14%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3448   +/-   ##
=====================================
  Coverage     61%     61%           
=====================================
  Files        610     611    +1     
  Lines      34185   34192    +7     
=====================================
+ Hits       20992   21003   +11     
+ Misses     13193   13189    -4     
Impacted Files Coverage Δ
common/functions/src/scalars/strings/length.rs 0% <0%> (ø)
common/functions/src/scalars/strings/string.rs 97% <100%> (+<1%) ⬆️
metasrv/src/store/meta_raft_store.rs 80% <0%> (+2%) ⬆️
common/management/src/cluster/cluster_mgr.rs 81% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f29cfc...2a35c41. Read the comment docs.

@BohuTANG
Copy link
Member

Stateless test failed:

[ FAIL ] - result differs with:
--- /home/runner/work/databend/databend/tests/suites/0_stateless/02_0040_function_strings_length.result	2021-12-13 23:12:56.176552939 +0000
+++ /home/runner/work/databend/databend/tests/suites/0_stateless/02_0040_function_strings_length.stdout	2021-12-13 23:19:15.927736136 +0000
@@ -1,5 +1,5 @@
-5
+4
 18
 28
-NULL
 6
+NULL

@BohuTANG
Copy link
Member

/lgtm

@BohuTANG
Copy link
Member

Unit Tests / Tests (macos-11) test failed is not related to this PR, merged.
Thank you @Blacksmith96 !

@BohuTANG BohuTANG merged commit 09b1aa2 into datafuselabs:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants