-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bloom filter for single column equivalent expression #3887
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/H7j4v1R6uftW3pak8Rsdvgn5yDQ2 |
Seems fasthash library faied aarch64 build |
Perhaps we could implement the bloom filter with another hashing algorithm, such as seahash. Or later I can add a 64-bit CityHash v102 implementation to naive-cityhash. |
I have just released naive-cityhash v0.2.0, supporting |
It is fine, we can use SeaHash for now. Thanks for the following up. |
Codecov Report
@@ Coverage Diff @@
## main #3887 +/- ##
======================================
Coverage 57% 57%
======================================
Files 770 774 +4
Lines 41103 41430 +327
======================================
+ Hits 23728 23950 +222
- Misses 17375 17480 +105
Continue to review full report at Codecov.
|
Docs about the cityhash in ClickHouse: |
/// We should have our custom none-state hash functions | ||
/// Tracked work item: https://github.com/datafuselabs/databend/issues/3897 | ||
#[derive(Clone)] | ||
pub enum DFHasher { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Add bloom filter for single column equivalent expression like "name = 'batman'".
Changelog
Related Issues
Related #3832
Test Plan
Unit Tests
Stateless Tests