Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-3898: Add partitions_total to Dal Context #3903

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

dantengsky
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

address issue #3898

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #3898

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/HiUJAwiEYPrYDocrhRL3fLkFGNmj
✅ Preview: Canceled

[Deployment for 15e9fe0 canceled]

common/dal/src/context.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #3903 (15e9fe0) into main (3a3abf7) will increase coverage by 0%.
The diff coverage is 92%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3903   +/-   ##
=====================================
  Coverage     57%     57%           
=====================================
  Files        773     773           
  Lines      41298   41276   -22     
=====================================
- Hits       23865   23863    -2     
+ Misses     17433   17413   -20     
Impacted Files Coverage Δ
query/src/interpreters/interpreter_query_log.rs 79% <75%> (-1%) ⬇️
common/dal/src/context.rs 81% <100%> (-1%) ⬇️
...ry/src/storages/fuse/operations/read_partitions.rs 97% <100%> (+<1%) ⬆️
query/src/storages/system/query_log_table.rs 85% <100%> (+<1%) ⬆️
common/grpc/src/dns_resolver.rs 21% <0%> (-22%) ⬇️
query/src/common/mod.rs 84% <0%> (-2%) ⬇️
common/ast/src/parser/expr/expr_visitor.rs 58% <0%> (-1%) ⬇️
common/meta/grpc/src/grpc_client.rs 0% <0%> (ø)
metasrv/src/meta_service/raftmeta.rs 48% <0%> (+<1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f96d2...15e9fe0. Read the comment docs.

@dantengsky dantengsky marked this pull request as ready for review January 19, 2022 06:58
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@BohuTANG BohuTANG merged commit d8cf752 into datafuselabs:main Jan 19, 2022
@databend-bot
Copy link
Member

Wait for another reviewer approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add partitions_total
4 participants