Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Func: repeat/substring/substr/mid #4102

Merged
merged 5 commits into from Feb 11, 2022

Conversation

Veeupup
Copy link
Collaborator

@Veeupup Veeupup commented Feb 11, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

string func:

  • repeat
  • substring
  • mid
  • substr
  • substring_index

Changelog

  • Improvement

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

3 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/BMrSSQJcYXRnBYfQ1Go84ojiDoaE
✅ Preview: https://databend-git-fork-veeupup-funcrepeatsubstring-databend.vercel.app

[Deployment for 306b83b canceled]

@Veeupup Veeupup marked this pull request as draft February 11, 2022 07:36
Signed-off-by: Veeupup <code@tanweime.com>
@Veeupup Veeupup marked this pull request as ready for review February 11, 2022 07:49
@sundy-li
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2022

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

Signed-off-by: Veeupup <code@tanweime.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4102 (306b83b) into main (c04dca4) will increase coverage by 0%.
The diff coverage is 38%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #4102    +/-   ##
======================================
  Coverage     57%     57%            
======================================
  Files        856     856            
  Lines      46510   46300   -210     
======================================
- Hits       26679   26633    -46     
+ Misses     19831   19667   -164     
Impacted Files Coverage Δ
...n/functions/src/scalars/strings/substring_index.rs 5% <6%> (+3%) ⬆️
common/functions/src/scalars/strings/repeat.rs 9% <8%> (+3%) ⬆️
common/functions/src/scalars/strings/substring.rs 78% <84%> (+35%) ⬆️
common/functions/src/scalars/strings/string.rs 98% <100%> (ø)
common/datavalues/src/arrays/string/builder.rs 43% <0%> (-13%) ⬇️
query/src/common/mod.rs 76% <0%> (-8%) ⬇️
common/datavalues/src/arrays/comparison.rs 6% <0%> (-5%) ⬇️
common/functions/src/scalars/function2_factory.rs 91% <0%> (-1%) ⬇️
...nctions/src/scalars/comparisons/comparison_like.rs 52% <0%> (-1%) ⬇️
common/datavalues/src/arrays/primitive/mod.rs 38% <0%> (-1%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04dca4...306b83b. Read the comment docs.

@sundy-li sundy-li merged commit 576a130 into datafuselabs:main Feb 11, 2022
@sundy-li
Copy link
Member

Good job, almost -300 LOC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants