Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metasrv): metasrv unittest logs tracing event with customized formatter #6874

Merged
merged 2 commits into from Jul 28, 2022

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat(metasrv): metasrv unittest logs tracing event with customized formatter

Move the logging config from common/tracing to metasrv/:
metasrv sometimes needs full span tracing to debug. It's a little
different from the logging requirement for query.

Changelog

Related Issues

…rmatter

Move the logging config from common/tracing to metasrv/:
`metasrv` sometimes needs full span tracing to debug. It's a little
different from the logging requirement for query.

- Revert meta ut logging config removed from datafuselabs#6845
@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 28, 2022 at 1:17PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 28, 2022
@drmingdrmer drmingdrmer changed the title feat(metasrv): metasrv unittest logs tracing event with customized formatter refactor(metasrv): metasrv unittest logs tracing event with customized formatter Jul 28, 2022
@drmingdrmer drmingdrmer marked this pull request as ready for review July 28, 2022 09:35
@drmingdrmer drmingdrmer requested a review from Xuanwo July 28, 2022 09:35
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 28, 2022
@mergify mergify bot merged commit 3ad86bc into datafuselabs:main Jul 28, 2022
@drmingdrmer drmingdrmer deleted the 2-meta-ut-tracing branch July 28, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants