Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): migrate trim functions to new expression framework. #6921

Merged
merged 11 commits into from Aug 2, 2022
Merged

feat(functions): migrate trim functions to new expression framework. #6921

merged 11 commits into from Aug 2, 2022

Conversation

RinChanNOWWW
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Migreate trim functions to new expression framework:

  • ltrim
  • rtrim
  • trim
  • trim_both
  • trim_leading
  • trim_trailing

P.S. trim will be transformed into trim_both or trim_leading or trim_trailing, but the transformation is only implemented for unit test now.

Fixes #6766

@vercel
Copy link

vercel bot commented Jul 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 2, 2022 at 11:42AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2022

This pull request's title is not fulfill the requirements. @RinChanNOWWW please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, refactor, ci, build, docs, website, chore

Valid types:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@RinChanNOWWW
Copy link
Member Author

PTAL @andylokandy

@RinChanNOWWW RinChanNOWWW changed the title Migreate trim functions to new expression framework. feat(functions): Migrate trim functions to new expression framework. Jul 31, 2022
@RinChanNOWWW RinChanNOWWW changed the title feat(functions): Migrate trim functions to new expression framework. feat(functions): migrate trim functions to new expression framework. Jul 31, 2022
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 31, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Aug 1, 2022

Conflicting files
common/functions-v2/src/scalars/string.rs
common/functions-v2/tests/it/scalars/string.rs

@RinChanNOWWW
Copy link
Member Author

RinChanNOWWW commented Aug 1, 2022

Conflicting files common/functions-v2/src/scalars/string.rs common/functions-v2/tests/it/scalars/string.rs

Will resolve soon.

common/functions-v2/src/scalars/string.rs Outdated Show resolved Hide resolved
common/functions-v2/src/scalars/string.rs Outdated Show resolved Hide resolved
common/functions-v2/src/scalars/string.rs Outdated Show resolved Hide resolved
common/functions-v2/src/scalars/string.rs Outdated Show resolved Hide resolved
common/functions-v2/src/scalars/string.rs Outdated Show resolved Hide resolved
common/functions-v2/src/scalars/string.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 223ad77 into datafuselabs:main Aug 2, 2022
@RinChanNOWWW RinChanNOWWW deleted the MIGREATE-TRIM branch August 2, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate String functions to new expression framework
5 participants