Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add alter share tenants sql #7044

Merged
merged 9 commits into from Aug 10, 2022
Merged

feat: add alter share tenants sql #7044

merged 9 commits into from Aug 10, 2022

Conversation

lichuang
Copy link
Collaborator

@lichuang lichuang commented Aug 9, 2022 •
edited by Xuanwo

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: add alter share tenants sql

Fixes #7043

@vercel
Copy link

vercel bot commented Aug 9, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 10, 2022 at 11:11PM (UTC)

@lichuang lichuang requested review from Xuanwo and leiysky August 9, 2022 02:59
@lichuang lichuang added the C-feature Category: feature label Aug 9, 2022
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 9, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Aug 9, 2022

Can you give me an rfc on how these features will in general? A overall picture makes it much easier for me to understand how share works.

So far, I don't how will share work. How will share play with grants, revoke, alter? So I can't decide whether current implementation is good or not.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 9, 2022 •
edited

Most important thing to me: the relation between share, tenant, users, database, catalog, table.

A full example that shows how users will play with share.

@lichuang
Copy link
Collaborator Author

lichuang commented Aug 9, 2022

Can you give me an rfc on how these features will in general? A overall picture makes it much easier for me to understand how share works.

So far, I don't how will share work. How will share play with grants, revoke, alter? So I can't decide whether current implementation is good or not.

https://docs.snowflake.com/en/user-guide/data-sharing-provider.html

Xuanwo
Xuanwo reviewed Aug 9, 2022
View reviewed changes
common/ast/src/ast/statements/share.rs Outdated Show resolved Hide resolved
common/ast/src/ast/statements/share.rs Outdated Show resolved Hide resolved
common/ast/src/ast/statements/share.rs Outdated Show resolved Hide resolved
common/ast/src/parser/statement.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Aug 10, 2022
View reviewed changes
common/ast/src/ast/statements/statement.rs Outdated Show resolved Hide resolved
common/ast/src/ast/statements/statement.rs Outdated Show resolved Hide resolved
common/ast/src/parser/statement.rs Outdated Show resolved Hide resolved
common/ast/src/parser/statement.rs Show resolved Hide resolved
common/ast/src/parser/statement.rs Outdated Show resolved Hide resolved
query/src/sql/planner/plans/share.rs Outdated Show resolved Hide resolved
query/src/sql/planner/plans/share.rs Outdated Show resolved Hide resolved
query/src/sql/planner/plans/share.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit bd12b79 into datafuselabs:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
C-feature Category: feature pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alter share tenants
3 participants
@lichuang @Xuanwo @BohuTANG