Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc: add share rfc #7059

Merged
merged 5 commits into from Aug 12, 2022
Merged

rfc: add share rfc #7059

merged 5 commits into from Aug 12, 2022

Conversation

lichuang
Copy link
Collaborator

@lichuang lichuang commented Aug 10, 2022 •
edited by Xuanwo

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

docs: add share rfc

Fixes #7058

@vercel
Copy link

vercel bot commented Aug 10, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 3:07AM (UTC)

@lichuang lichuang requested a review from Xuanwo August 10, 2022 03:30
@lichuang lichuang added C-documentation Category: documentation pr-doc this PR needs/changes the documents or websites labels Aug 10, 2022
@Xuanwo Xuanwo changed the title docs: add share rfc rfc: add share rfc Aug 10, 2022
@mergify mergify bot added the pr-rfc label Aug 10, 2022
@Xuanwo Xuanwo removed the pr-doc this PR needs/changes the documents or websites label Aug 10, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Aug 10, 2022 •
edited

FYI: This PR's type is rfc, which requires three approval to be merged.

Added reviewers: @Xuanwo @ZhiHanZ @flaneur2020 @drmingdrmer

@BohuTANG
Copy link
Member

It would be better to introduce the share with consumers and producers model.
Like the chapter of DDL for shares is producers operation, and CREATE DATABASE <name> FROM SHARE <provider_tenant>.<share_name> is comsumer operation.
For a consumer, we should make some questions to be clear:

  1. what are the privileges(permission) for the shared database shared by the producer?
  2. what will happen to the producer when the consumer drop the <shared-database>?
  3. what will happen to the consumer if the producer drops the shared database?

flaneur2020
flaneur2020 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍

@Xuanwo Xuanwo mentioned this pull request Aug 12, 2022
Closed
@Xuanwo
Copy link
Member

Xuanwo commented Aug 12, 2022

It would be better to introduce the share with consumers and producers model.

Created an issue #7094 to track this.

@mergify mergify bot merged commit bded50e into datafuselabs:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

@drmingdrmer drmingdrmer drmingdrmer approved these changes

@flaneur2020 flaneur2020 flaneur2020 approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

@ZhiHanZ ZhiHanZ Awaiting requested review from ZhiHanZ

Assignees
No one assigned
Labels
C-documentation Category: documentation pr-rfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC of share
5 participants
@lichuang @Xuanwo @BohuTANG @drmingdrmer @flaneur2020