feat(meta-service): add metrics last_seq
#7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: - Refactor: subscribe_metrics() does not need to watch another Receiver: `MetaNode.running_rx` for shutting down event. When MetaNode is shutting down, `metrics_rx.changed()` returns an error indicating Raft is shutting down. - Refactor: reduce indent `:()` - Fix: datafuselabs#7395
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
drmingdrmer
added
C-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
feat(meta-service): add metrics
last_seqOther changes:
Refactor: subscribe_metrics() does not need to watch another Receiver:
MetaNode.running_rxfor shutting down event.When MetaNode is shutting down,
metrics_rx.changed()returns anerror indicating Raft is shutting down.
Refactor: reduce indent
:()Fix: databend-meta report
last_seqmetrics #7395Changelog
Related Issues