Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(format): better checking of format options. #8981

Merged
merged 20 commits into from
Nov 26, 2022
Merged

feat(format): better checking of format options. #8981

merged 20 commits into from
Nov 26, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 26, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • check format by format:
  1. report errors when option that should not use, e.g. field_delimeter for Parquet
  2. set format`s own default if meet "" for some options.
  • real enable option nan_display
  • almost remove the usage of FormatSetting, leave alone the usage in Variant, which will be remove after new expression is used Feature: remove FormatSettings. #8949
  • some other refactor.

Closes #8949 #8935

@vercel
Copy link

vercel bot commented Nov 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Nov 26, 2022 at 0:06AM (UTC)

@youngsofun youngsofun requested review from ariesdevil, sundy-li and TCeason and removed request for ariesdevil and sundy-li November 26, 2022 08:24
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Nov 26, 2022
@BohuTANG
Copy link
Member

Two failed tests need to be addressed:
Dev Linux / test_stateful_standalone_linux (pull_request) Failing after 8m
Dev Linux / test_stateful_cluster_linux (pull_request) Failing after 11m

@mergify mergify bot merged commit f4a4ea8 into datafuselabs:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@ariesdevil ariesdevil ariesdevil approved these changes

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: remove FormatSettings.
5 participants
@youngsofun @BohuTANG @sundy-li @ariesdevil @TCeason